New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix feed.xml.builder breaking on empty blogs #155

Merged
merged 1 commit into from Sep 17, 2013

Conversation

Projects
None yet
2 participants
@barraponto
Contributor

barraponto commented Sep 6, 2013

No description provided.

@bhollis

This comment has been minimized.

Show comment
Hide comment
@bhollis

bhollis Sep 7, 2013

Member

Thanks! But why have a blog if it's empty?

Also, the second guard isn't necessary:

> [][0..5]
 => []
Member

bhollis commented Sep 7, 2013

Thanks! But why have a blog if it's empty?

Also, the second guard isn't necessary:

> [][0..5]
 => []
@barraponto

This comment has been minimized.

Show comment
Hide comment
@barraponto

barraponto Sep 7, 2013

Contributor
  1. The user might start working on the layout and css for a blog-enabled project that doesn't have a post yet.
  2. Writing new blog-enabled templates will require a sample post not to break out-of-the-box.
  3. I bet multi-blogs will find this useful.
Contributor

barraponto commented Sep 7, 2013

  1. The user might start working on the layout and css for a blog-enabled project that doesn't have a post yet.
  2. Writing new blog-enabled templates will require a sample post not to break out-of-the-box.
  3. I bet multi-blogs will find this useful.

bhollis added a commit that referenced this pull request Sep 17, 2013

Merge pull request #155 from barraponto/patch-2
Fix feed.xml.builder breaking on empty blogs

@bhollis bhollis merged commit 03af217 into middleman:master Sep 17, 2013

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment