Support editing a blog post after creating it with -e

[nogweii]

Passing -e or --edit to 'middleman article' will open the user's $EDITOR
with the new blog post. It will fall back to vi if $EDITOR hasn't been exported.
(A fairly normal behaviour in Linux anyways.)

Closes #201.

[karlfreeman]

Quite like this, but perhaps if there is no $EDITOR set it simply does not edit the article? instead of assuming vi?

[bhollis]

This is great, but I don't think it'll work right on Windows, and it won't open the file in a GUI editor on Mac. We're going to need to figure out a cross-platform way of opening the file in the user's preferred editor.

[nogweii]

I don't think it'll work right on Windows, and it won't open the file in a GUI editor on Mac.

I don't think there are any problems, so long as $EDITOR is set to the editor's binary. I also think system() would work on Windows for our use-case, but I'm not 100%.

[coveralls]

Coverage remained the same when pulling e77aadd on evaryont:edit-new-article into 394e8f4 on middleman:master.

[coveralls]

Coverage remained the same when pulling e77aadd on evaryont:edit-new-article into 394e8f4 on middleman:master.

[bhollis]

I think I'd want to do some experiments on OS X and Windows to make sure it'll do what users expect.

[bhollis]

Yeah, this is tricky. EDITOR is nice for CLI editors like emacs or vim, but I use a GUI markdown editor (Mou) just for Markdown files, and that's my default program for opening them. So for me, on OS X, I'd want to call open to open my article in Mou, even though my EDITOR is emacs. On Windows, I would just want to call start on the file to open it in my default editor. On *nix, I'd want to run xdg-open or kde-open or gnome-open, unless they really did want to use EDITOR.

I'm not sure how to make everyone happy without a ton of weird platform-specific code and platform detection.

[karlfreeman]

@bhollis 👍. It might be more frustrating that this works sometimes for some people than the benefit this feature brings.

[nogweii]

I can see that, quite a rabbit hole.

Instead, how about something like --editor=BINARY? Perhaps paired with an
option in config.rb. I think that handles pretty much every use case,
though a little bit more manually.
On Mar 24, 2014 11:42 PM, "Ben Hollis" notifications@github.com wrote:

Yeah, this is tricky. EDITOR is nice for CLI editors like emacs or vim,
but I use a GUI markdown editor (Mou) just for Markdown files, and that's
my default program for opening them. So for me, on OS X, I'd want to call
open to open my article in Mou, even though my EDITOR is emacs. On
Windows, I would just want to call start on the file to open it in my
default editor. On *nix, I'd want to run xdg-open or kde-open or
gnome-open, unless they really did want to use EDITOR.

I'm not sure how to make everyone happy without a ton of weird
platform-specific code and platform detection.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/203#issuecomment-38535026
.

[bhollis]

Here's another proposal, based off what Git does. We could check a MM_EDITOR environment variable and use that, then fall back to EDITOR, then raise an exception if that's not present. That avoids hardcoding vim, and gives users an option to set an editor specific to Middleman - so I could set it to open while others could use vim or notepad.exe or whatever.

[karlfreeman]

@bhollis 👍.

[tdreyno]

👍 I think Sublime and Bundler follow this convention too.

[coveralls]

Coverage decreased (-0.9%) to 93.617% when pulling 4ce6c51 on evaryont:edit-new-article into fe6f382 on middleman:master.

[nogweii]

Wow, I lost track of this PR. Here it is, revivied.

I've implemented @bhollis suggested algorithim. It'll look for $MM_EDITOR and fall back to $EDITOR. If neither is set, it will suggest setting MM_EDITOR. All of this is opt-in, and if I got my ruby right, shouldn't change any current behaviours.

[coveralls]

Coverage decreased (-1.3%) to 93.193% when pulling 7dd4b0b on evaryont:edit-new-article into fe6f382 on middleman:master.

[coveralls]

Coverage decreased (-0.9%) to 93.617% when pulling 2d9147e on evaryont:edit-new-article into fe6f382 on middleman:master.

[tdreyno]

Wow, the 2 year old PR bump :) Awesome.