Update blog_article active_support requires. Fixes #205 #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it is better to be explicit. Ruby already has slow startup time and a lot of that is just reading files off disk. Avoiding "include everything" scenarios, especially with ActiveSupport which monkey patches everything, should be avoided. Thanks for tracking this down. |
|
Yeah, that makes sense. This fix actually kinda sucks because we aren't even calling |
|
👍 |
|
@adamesque It does seem like a missing dependency on the activesupport side. |
bhollis
added a commit
that referenced
this pull request
May 2, 2014
Update blog_article active_support requires. Fixes #205
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell, requiring
activesupport/core_ext/time/acts_likekeeps us from taking a bad branch at https://github.com/rails/rails/blob/master/activesupport/lib/active_support/core_ext/date_and_time/zones.rb#L21 which leads to an exception when callingto_timewith a parameter.I wonder, though, if it might be easier just to include all the ActiveSupport Time
core_exts rather than cherry-pick at this granularity.