Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Port the extension to the new sitemap structure #41

Merged
merged 9 commits into from Apr 21, 2012

Conversation

Projects
None yet
2 participants
Owner

bhollis commented Apr 21, 2012

The new sitemap stuff is really cool - it lets me fix #39 easily because the page list gets rebuilt completely whenever stuff changes.

I'd definitely like comments on the approaches I took here - specifically how I'm using manipulate_resource_list and how I made BlogArticle into a module that just gets mixed into Resource. I was also pretty uncomfortable with what I had to do in TagPages and CalendarPages to set instance variables in the views using provides_metadata_for_path, especially since each time the sitemap is rebuilt a new block is added to that list and they just build up. I'd love to come up with a better way of handling that.

All tests pass assuming middleman/middleman#367 is pulled.

Owner

tdreyno commented Apr 21, 2012

Great!

@tdreyno tdreyno added a commit that referenced this pull request Apr 21, 2012

@tdreyno tdreyno Merge pull request #41 from bhollis/new_sitemap
Port the extension to the new sitemap structure
a4fe6d4

@tdreyno tdreyno merged commit a4fe6d4 into middleman:master Apr 21, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment