New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the missing file back for the automatic_alt_tag feature #1072

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@stevenosloan
Contributor

stevenosloan commented Nov 14, 2013

Just noticed this working off master for the meta page asset paths --- I believe this is coming from the removal of the automatic_alt_tags.rb file in b813db3

/Users/username/code/middleman/middleman-core/lib/middleman-core/core_extensions.rb:94:in `require': cannot load such file -- middleman-more/extensions/automatic_alt_tags (LoadError)

Assuming the specs are good -- should be good to go from here.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Nov 14, 2013

Coverage Status

Coverage increased (+63.95%) when pulling 3ad0165 on stevenosloan:add_missing_file_for_auto_alt_tag_feature into 4da2b02 on middleman:master.

coveralls commented Nov 14, 2013

Coverage Status

Coverage increased (+63.95%) when pulling 3ad0165 on stevenosloan:add_missing_file_for_auto_alt_tag_feature into 4da2b02 on middleman:master.

@tdreyno

This comment has been minimized.

Show comment
Hide comment
@tdreyno

tdreyno Nov 14, 2013

Member

Derp. Fixed this myself. Bad rename.

Member

tdreyno commented Nov 14, 2013

Derp. Fixed this myself. Bad rename.

@tdreyno tdreyno closed this Nov 14, 2013

@renatocarvalho

This comment has been minimized.

Show comment
Hide comment
@renatocarvalho

renatocarvalho Aug 2, 2014

Hi there, I just noticed that this issue might be happening again. I'm getting an error when I try to activate activate :automatic_alt_tags on my config.rb.

  1. Using gem 'middleman', '~>3.3.3'
  2. On my config.rb I have activate :automatic_alt_tags
  3. On my index.slim I'm calling the image helper = image_tag 'video.jpg'

The error I get is:

NameError at /
undefined local variable or method `params' for #<Middleman::Application:0x2220387840>

When I remove the activate :automatic_alt_tags works fine.

renatocarvalho commented Aug 2, 2014

Hi there, I just noticed that this issue might be happening again. I'm getting an error when I try to activate activate :automatic_alt_tags on my config.rb.

  1. Using gem 'middleman', '~>3.3.3'
  2. On my config.rb I have activate :automatic_alt_tags
  3. On my index.slim I'm calling the image helper = image_tag 'video.jpg'

The error I get is:

NameError at /
undefined local variable or method `params' for #<Middleman::Application:0x2220387840>

When I remove the activate :automatic_alt_tags works fine.

@tdreyno

This comment has been minimized.

Show comment
Hide comment
@tdreyno

tdreyno Aug 3, 2014

Member

@renatocarvalho Please make a new issue, thanks.

Member

tdreyno commented Aug 3, 2014

@renatocarvalho Please make a new issue, thanks.

@renatocarvalho

This comment has been minimized.

Show comment
Hide comment
@renatocarvalho

renatocarvalho commented Aug 3, 2014

@tdreyno Ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment