Handle page id's that are Fixnums #2033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, should be able to remove that fixture. The Queryable interface died in v4. |
|
Nuked and pushed.
--
Kenneth Kalmer
@kennethkalmer
http://www.opensourcery.co.za
|
|
@tdreyno anything else required to get this merged? The failure is related to Liquid templates being broken |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2032.
I have no idea how to even trace the issue. Maybe something changed in ActiveSupport?
Also, should I nuke the
queryable-appfixture since it isn't used anywhere, but had Fixnum page id's (thus leading to false assumptions of the state of the code).