Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conform generated gemspec to `bundle gem` style #2294

Open
wants to merge 3 commits into
base: master
from

Conversation

@unasuke
Copy link
Contributor

unasuke commented Oct 9, 2019

Motivation

In executing $ bundle gem, gemspec contains git user.name and user.email automatically.
And place TODO to the field to must update. It's very useful.

Changes

  • remove obsoleteness magic comment
    • # -*- encoding: utf-8 -*-
  • authors and email from git config
  • uncomment and add TODO to homepage, summary, and description
@unasuke unasuke force-pushed the unasuke:generate_extension branch from 79c1b53 to 0ec8890 Oct 10, 2019
@unasuke unasuke changed the title Conform gemspec to `bundle gem` style Conform generated gemspec to `bundle gem` style Oct 10, 2019
@tdreyno

This comment has been minimized.

Copy link
Member

tdreyno commented Oct 10, 2019

This is very nice. Is there a way to check if the shelling out to git is safe on Windows?

@unasuke

This comment has been minimized.

Copy link
Contributor Author

unasuke commented Oct 10, 2019

@tdreyno

Is there a way to check if the shelling out to git is safe on Windows?

In bundler, they checking git.exe

https://github.com/bundler/bundler/blob/fe5d24b5dc6614c0edfee8407acba14aa610ac72/lib/bundler.rb#L529-L532

Maybe Windows (cmd.exe) can use which too.
https://stackoverflow.com/questions/304319/is-there-an-equivalent-of-which-on-the-windows-command-line

I'll confirm later! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.