Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace aruba's deprecated method to the new method #2310

Merged
merged 4 commits into from Jan 29, 2020

Conversation

@unasuke
Copy link
Contributor

unasuke commented Jan 23, 2020

Those four APIs are now deprecated.
So I replaced to the new APIs.

  1. #run
  2. #set_env
  3. #current_dir
  4. #announcer
unasuke added 4 commits Jan 23, 2020
Aruba's #run methods now deprecated.
Use new method #run_command.

- cucumber/aruba#585
Aruba's #set_env methods now deprecated.
Use new method #set_environment_variable.

- cucumber/aruba@663991e
Aruba's #current_dir now deprecated.
Use new method #expand_path.

- cucumber/aruba@802c4ec
Aruba's #announcer now deprecated.
Use new method aruba.announcer.

- cucumber/aruba@7f8a155
@tdreyno

This comment has been minimized.

Copy link
Member

tdreyno commented Jan 29, 2020

Awesome. Thank you.

@tdreyno tdreyno merged commit c934366 into middleman:master Jan 29, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@unasuke unasuke deleted the unasuke:deprecated_aruba_methods branch Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.