Friendlier bundle install step #352

Merged
merged 1 commit into from Apr 14, 2012

Projects

None yet

2 participants

@bhollis
Member
bhollis commented Apr 9, 2012

This leans on Thor a bit more to run bundle install, and silences its output.

@tdreyno
Member
tdreyno commented Apr 9, 2012

Hmm, wondering if Bundler doesn't have a simpler Ruby API to do this instead of shelling out?

@bhollis
Member
bhollis commented Apr 10, 2012

Not really. We could require and invoke the Bundler install Thor task directly, but that's not much better than shelling out.

@tdreyno
Member
tdreyno commented Apr 10, 2012

Maybe:

Bundler::Installer.install(Bundler.root, Bundler.definition, opts)

Then maybe we could control our own versioning like:

`middleman update`
@bhollis
Member
bhollis commented Apr 12, 2012

How would you suggest that stuff work? What would it do above and beyond bundle install?

@tdreyno
Member
tdreyno commented Apr 12, 2012

I'm just thinking for non-dev users, if they want to update their version of Middleman, we can avoid Rubygems and Bundler entirely. It would just run bundle update internally.

Additionally, having the Gemfile.lock would make it easy to see which versions of gems were used when debugging bugs.

@bhollis
Member
bhollis commented Apr 13, 2012

Not a bad idea. Maybe I could merge this pull in the meantime, though?

@tdreyno
Member
tdreyno commented Apr 13, 2012

Go for it.

@bhollis bhollis merged commit db0febe into middleman:master Apr 14, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment