Reorder extensions so frontmatter is available before sitemap #367

Merged
merged 2 commits into from Apr 21, 2012

Projects

None yet

2 participants

@bhollis
Middleman member

The one downside with all the callback-based stuff is if the callbacks run in the wrong order, you can get in trouble. One thing that was tripping me up working on the blog extension is that frontmatter gets populated after the sitemap stuff, so the resource manipulators couldn't use frontmatter info. This reorders it so frontmatter is always available before the sitemap is rebuilt.

I had to change rendering around too because moving frontmatter broke that. It's all very delicate...

@bhollis bhollis referenced this pull request in middleman/middleman-blog Apr 21, 2012
Merged

Port the extension to the new sitemap structure #41

@tdreyno
Middleman member

Yeah, there's really no mechanism for saying that one extension depends on another.

@tdreyno tdreyno merged commit c5aa707 into middleman:master Apr 21, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment