Skip to content

Added HTML5-HAML and SMACSS to middleman-more templates #561

Closed
wants to merge 4 commits into from

3 participants

@dannyprose

Thomas,

Please double check how I did this...I copied the the format for templates in middleman-core.

@tdreyno

Interesting, never seen this format before.

This is where SMACSS organization style comes in, but mixins and reset aren't needed (I'll remove) while grid and btn are there mostly to get people started. If you're using SMACSS you'd mostly be making more files to go in the module folder.

@tdreyno

Why does this not just Compass?

I'll clean this out, it's not needed for SMACSS organization style

@tdreyno

Are these necessary for SMACCS or just copied out of another template? I'd like to sure the "shared" config.rb if possible (I can show you how).

These are not necessary. Should I just remove the config file? Thanks in advance for help.

Middleman member

Yeah, just remove the config, I'll wire up the "default" config after this is merged.

Ok, well actually, back over here I think I have the default config back in place now. Other changes noted here are applied too. https://github.com/nsteiner/middleman-smacss
Not sure if there's something else I can do to help.

@tdreyno
Middleman member
tdreyno commented Aug 9, 2012

I'd rather if both these templates were in this repo, without using submodules.

Additionally, can you squash these commits into a single one?

@dannyprose

I believe most of these questions are for @nsteiner.

I'll get HTML5-HAML copied properly and squash the whole thing.

@tdreyno
Middleman member
tdreyno commented Aug 9, 2012

Go ahead and update the CHANGELOG too

@nsteiner
nsteiner commented Aug 9, 2012

I've updated the original middleman-smacss, should I do a pull request and replicate the changes here? https://github.com/nsteiner/middleman-smacss
Thank you both for your patience, learning here.

@tdreyno
Middleman member
tdreyno commented Aug 9, 2012

Yeah, @dannyprose if you'll remove smacss from your PR I can merge the Haml stuff separately.

@nsteiner Send me a pull request, similar to this one with the updates and we can track that in another thread.

@tdreyno
Middleman member
tdreyno commented Aug 14, 2012

Ping @dannyprose? Squash and rebase please.

@dannyprose
@tdreyno
Middleman member
tdreyno commented Dec 25, 2012

Looks like this never happened. Closing, probably easier for @dannyprose to re-evaluate what needs to be done and send a fresh Pull Request.

@tdreyno tdreyno closed this Dec 25, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.