Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding smacss submodule #562

Merged
merged 3 commits into from Aug 14, 2012
Merged

adding smacss submodule #562

merged 3 commits into from Aug 14, 2012

Conversation

onezerodigits
Copy link
Contributor

Ok adding smaccs template files as a submodule. I think I did this right sweating

@tdreyno
Copy link
Member

tdreyno commented Aug 10, 2012

Sorry if I miscommunicated. This needs to be a commit of the files in your repo, but not a submodule. It's generally a pain to get users, and build systems, to remember to use git submodules.

@onezerodigits
Copy link
Contributor Author

Ah - thanks, my fault. Will do.

@tdreyno
Copy link
Member

tdreyno commented Aug 10, 2012

Looks good, I'll merge this in over the weekend. Thanks!

tdreyno added a commit that referenced this pull request Aug 14, 2012
@tdreyno tdreyno merged commit b3fd862 into middleman:master Aug 14, 2012
@tdreyno
Copy link
Member

tdreyno commented Aug 14, 2012

All in. Thanks!

@joefiorini
Copy link
Contributor

Why do we have numbers prefixing all the file names? Why not make directories for each logical grouping and have separate small files instead?

@onezerodigits
Copy link
Contributor Author

The numbers enforce and inform the ordering, but doing that is certainly a personal pref kinda thing. @joefiorini should we change it?

@joefiorini
Copy link
Contributor

The way I've always done SMACSS is to my SASS imports determine the
ordering, and break out my modules/layout/states into lots of small files.
Then I let the awesomeness of Middleman & Sprockets concatenate it for me
:) I'd be happy to take a stab at early next week unless you'd like to try
it sooner.

On Fri, Aug 24, 2012 at 5:19 PM, Nate Steiner notifications@github.comwrote:

The numbers enforce and inform the ordering, but doing that is certainly a
personal pref kinda thing. Should we change it?


Reply to this email directly or view it on GitHubhttps://github.com//pull/562#issuecomment-8015150.

@onezerodigits
Copy link
Contributor Author

Go for it @joefiorini that sounds like an improvement. I just inherited the numbering idea from another developer, it might be weird.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants