turn html5 boilerplate into a layout #678

Merged
merged 1 commit into from Dec 15, 2012

Projects

None yet

3 participants

@barraponto
Contributor

This is a very lightweight change to them html5 template, to use h5bp as a default layout for the template, instead of a default page. This is a really really subtle change when compared to #561

@barraponto
Contributor

Also, this is easily backportable to 3.0.x branch, I'm using it locally with no issues.

@tdreyno
Member
tdreyno commented Dec 3, 2012

I think this is a great idea, but it also means that maintenance (updating our copy of h5bp) is more involved. I think it's worth it.

@barraponto
Contributor

As you can see, there are only two changes: adding erb lines to both title and content. It's fairly trivial.

@tdreyno
Member
tdreyno commented Dec 4, 2012

This fails the unit tests, looks like you renamed a file that the CLI test expects to exist. If you can fix that up, get this passing Travis tests, we'll merge.

@barraponto
Contributor

Oh crap, Travis is failing due to an update to therubyracer gem. Added a pull request to fix that: #681

@bhollis
Member
bhollis commented Dec 14, 2012

@barraponto, could you squash this into a single commit? Thanks!

@barraponto barraponto turn html5 boilerplate into a layout
set hbp5 as the DEFAULT layout

use titles from YAML options
60fc4ce
@barraponto
Contributor

There you go.

@tdreyno tdreyno merged commit d119ac1 into middleman:master Dec 15, 2012

1 check failed

default The Travis build failed
Details
@tdreyno
Member
tdreyno commented Dec 15, 2012

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment