Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds libv8 to the Gemfile, fixes #680 #681

Closed
wants to merge 2 commits into from

Conversation

@barraponto
Copy link
Contributor

@barraponto barraponto commented Dec 7, 2012

I'm a little bit worried that adding libv8 might make the travis build go over the timeout limit, as mentioned in StackOverflow

Just note that libv8 can take a significant amount of time to install and I've noticed that it may end up being the cause of going over Travis CI's timeout limits, causing your build to fail.

Let's see how Travis handles this. If it fails, we can always lock therubyracer to 0.10

@barraponto
Copy link
Contributor Author

@barraponto barraponto commented Dec 7, 2012

Reported build timeouts upstream. In the meanwhile, should we fix it by capping therubyracer version to 0.10.2?

@tdreyno
Copy link
Member

@tdreyno tdreyno commented Dec 8, 2012

Sounds like a good idea.

@tdreyno
Copy link
Member

@tdreyno tdreyno commented Dec 25, 2012

Going to stick with locking therubyracer for now. Will revisit in the future.

@tdreyno tdreyno closed this Dec 25, 2012
@barraponto
Copy link
Contributor Author

@barraponto barraponto commented Dec 26, 2012

This PR locks libv8 instead of therubyracer

@tdreyno
Copy link
Member

@tdreyno tdreyno commented Dec 26, 2012

Right, Travis seems to be fine now, so this isn't necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.