adds libv8 to the Gemfile, fixes #680 #681

Closed
wants to merge 2 commits into
from

Projects

None yet

2 participants

@barraponto
Contributor

I'm a little bit worried that adding libv8 might make the travis build go over the timeout limit, as mentioned in StackOverflow

Just note that libv8 can take a significant amount of time to install and I've noticed that it may end up being the cause of going over Travis CI's timeout limits, causing your build to fail.

Let's see how Travis handles this. If it fails, we can always lock therubyracer to 0.10

@barraponto
Contributor

Reported build timeouts upstream. In the meanwhile, should we fix it by capping therubyracer version to 0.10.2?

@tdreyno
Member
tdreyno commented Dec 8, 2012

Sounds like a good idea.

@tdreyno
Member
tdreyno commented Dec 25, 2012

Going to stick with locking therubyracer for now. Will revisit in the future.

@tdreyno tdreyno closed this Dec 25, 2012
@barraponto
Contributor

This PR locks libv8 instead of therubyracer

@tdreyno
Member
tdreyno commented Dec 26, 2012

Right, Travis seems to be fine now, so this isn't necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment