Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document livereload usage in config file #840

Merged
merged 2 commits into from May 3, 2013

Conversation

@barraponto
Copy link
Contributor

@barraponto barraponto commented Mar 26, 2013

Trying to make it easier for users to livereload their middleman projects.

Two questions, though:

  1. Should config.rb require "middleman-livereload" the way middleman-smusher does?
  2. Should I suggest gem install middleman-livereload" or adding it to the Gemfile and running bundle install?
@tdreyno
Copy link
Member

@tdreyno tdreyno commented Mar 26, 2013

  1. Middleman auto discovers gems in the Gemfile, so this is unnecessary.
  2. Always use Bundler
@barraponto
Copy link
Contributor Author

@barraponto barraponto commented Mar 26, 2013

@tdreyno so I can get away wih removing the "require middleman-smusher"?

@bhollis
Copy link
Member

@bhollis bhollis commented Apr 4, 2013

I'd honestly rather only advertise extensions built into middleman in the generated config - we should remove the "susy" and "middleman-smusher" suggestions and just link to the extensions list on the guides site. @tdreyno, what do you think?

@barraponto
Copy link
Contributor Author

@barraponto barraponto commented Apr 4, 2013

If installed middleman extensions could hook into middleman init and add commented tidbits to the config file, the extension developers would be in charge of mantaining them themselves. And users wouldn't miss these very useful instructions.

@tdreyno
Copy link
Member

@tdreyno tdreyno commented Apr 4, 2013

@bhollis Yeah, the default config should be simplified. Maybe just a list of popular extensions and a link to the extension docs? People should know that livereload is officially supported.

@jm3
Copy link

@jm3 jm3 commented Apr 20, 2013

@bhollis i agree, it seems odd to have things like susy in the default config.rb

@tdreyno
Copy link
Member

@tdreyno tdreyno commented Apr 21, 2013

Lots of people seem to use livereload. What if we include it by default (like middleman-sprockets) and add this option to the config.rb

@bhollis
Copy link
Member

@bhollis bhollis commented Apr 22, 2013

Sounds good to me, now that it does livereload by injecting JS rather than relying on a browser extension.

@barraponto
Copy link
Contributor Author

@barraponto barraponto commented Apr 23, 2013

🍺 that'd be great.

@jm3
Copy link

@jm3 jm3 commented Apr 23, 2013

+1

bhollis added a commit that referenced this pull request May 3, 2013
Document livereload usage in config file
@bhollis bhollis merged commit 3080857 into middleman:master May 3, 2013
1 check failed
1 check failed
@tdreyno
default The Travis build failed
Details
@bhollis
Copy link
Member

@bhollis bhollis commented May 3, 2013

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants