New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document livereload usage in config file #840

Merged
merged 2 commits into from May 3, 2013

Conversation

Projects
None yet
4 participants
@barraponto
Contributor

barraponto commented Mar 26, 2013

Trying to make it easier for users to livereload their middleman projects.

Two questions, though:

  1. Should config.rb require "middleman-livereload" the way middleman-smusher does?
  2. Should I suggest gem install middleman-livereload" or adding it to the Gemfile and running bundle install?
@tdreyno

This comment has been minimized.

Show comment
Hide comment
@tdreyno

tdreyno Mar 26, 2013

Member
  1. Middleman auto discovers gems in the Gemfile, so this is unnecessary.
  2. Always use Bundler
Member

tdreyno commented Mar 26, 2013

  1. Middleman auto discovers gems in the Gemfile, so this is unnecessary.
  2. Always use Bundler
@barraponto

This comment has been minimized.

Show comment
Hide comment
@barraponto

barraponto Mar 26, 2013

Contributor

@tdreyno so I can get away wih removing the "require middleman-smusher"?

Contributor

barraponto commented Mar 26, 2013

@tdreyno so I can get away wih removing the "require middleman-smusher"?

@bhollis

This comment has been minimized.

Show comment
Hide comment
@bhollis

bhollis Apr 4, 2013

Member

I'd honestly rather only advertise extensions built into middleman in the generated config - we should remove the "susy" and "middleman-smusher" suggestions and just link to the extensions list on the guides site. @tdreyno, what do you think?

Member

bhollis commented Apr 4, 2013

I'd honestly rather only advertise extensions built into middleman in the generated config - we should remove the "susy" and "middleman-smusher" suggestions and just link to the extensions list on the guides site. @tdreyno, what do you think?

@barraponto

This comment has been minimized.

Show comment
Hide comment
@barraponto

barraponto Apr 4, 2013

Contributor

If installed middleman extensions could hook into middleman init and add commented tidbits to the config file, the extension developers would be in charge of mantaining them themselves. And users wouldn't miss these very useful instructions.

Contributor

barraponto commented Apr 4, 2013

If installed middleman extensions could hook into middleman init and add commented tidbits to the config file, the extension developers would be in charge of mantaining them themselves. And users wouldn't miss these very useful instructions.

@tdreyno

This comment has been minimized.

Show comment
Hide comment
@tdreyno

tdreyno Apr 4, 2013

Member

@bhollis Yeah, the default config should be simplified. Maybe just a list of popular extensions and a link to the extension docs? People should know that livereload is officially supported.

Member

tdreyno commented Apr 4, 2013

@bhollis Yeah, the default config should be simplified. Maybe just a list of popular extensions and a link to the extension docs? People should know that livereload is officially supported.

@jm3

This comment has been minimized.

Show comment
Hide comment
@jm3

jm3 Apr 20, 2013

@bhollis i agree, it seems odd to have things like susy in the default config.rb

jm3 commented Apr 20, 2013

@bhollis i agree, it seems odd to have things like susy in the default config.rb

@tdreyno

This comment has been minimized.

Show comment
Hide comment
@tdreyno

tdreyno Apr 21, 2013

Member

Lots of people seem to use livereload. What if we include it by default (like middleman-sprockets) and add this option to the config.rb

Member

tdreyno commented Apr 21, 2013

Lots of people seem to use livereload. What if we include it by default (like middleman-sprockets) and add this option to the config.rb

@bhollis

This comment has been minimized.

Show comment
Hide comment
@bhollis

bhollis Apr 22, 2013

Member

Sounds good to me, now that it does livereload by injecting JS rather than relying on a browser extension.

Member

bhollis commented Apr 22, 2013

Sounds good to me, now that it does livereload by injecting JS rather than relying on a browser extension.

@barraponto

This comment has been minimized.

Show comment
Hide comment
@barraponto

barraponto Apr 23, 2013

Contributor

🍺 that'd be great.

Contributor

barraponto commented Apr 23, 2013

🍺 that'd be great.

@jm3

This comment has been minimized.

Show comment
Hide comment
@jm3

jm3 commented Apr 23, 2013

+1

bhollis added a commit that referenced this pull request May 3, 2013

Merge pull request #840 from barraponto/livereload_instructions
Document livereload usage in config file

@bhollis bhollis merged commit 3080857 into middleman:master May 3, 2013

1 check failed

default The Travis build failed
Details
@bhollis

This comment has been minimized.

Show comment
Hide comment
@bhollis

bhollis May 3, 2013

Member

Thanks!

Member

bhollis commented May 3, 2013

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment