Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types for httpSecurityHeaders #302

Merged
merged 3 commits into from Mar 13, 2019
Merged

Conversation

crespowang
Copy link
Contributor

I noticed the types for httpSecurityHeaders is added in 1.0.0-alpha but not master, so just do it to make it work for now.

@codecov
Copy link

codecov bot commented Feb 20, 2019

Codecov Report

Merging #302 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #302   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          19     19           
  Lines         511    511           
  Branches      105    105           
=====================================
  Hits          511    511

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfc0699...cbca009. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 20, 2019

Codecov Report

Merging #302 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #302   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          19     19           
  Lines         511    511           
  Branches      105    105           
=====================================
  Hits          511    511

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c464859...7e18286. Read the comment docs.

@lmammino
Copy link
Member

Thanks, seems great at a first glance. I'll review this better and get it merged in the next few hours :)

@lmammino lmammino merged commit 1d04aef into middyjs:master Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants