Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
Merge pull request #912 from arucard21/noVerifySSL_midgetspy
modified URL openers so they do not check SSL certificates (fixes #2551)
- Loading branch information
Showing
17 changed files
with
220 additions
and
250 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
79cb8f2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After this commit, xbmc/kodi and plex notifications no longer work
Clicking the test button shows "Test XBMC notice failed to 192.168.1.XX:XXXX" for xbmc and "Please fill out the necessary fields above." for plex
79cb8f2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same issue as aptalca - Plex does not work for me.
I get the error "Please fill out the necessary fields above":
Manually trying to update Plex from the SickBeard homepage shows the following 500 Internal Server Error:
79cb8f2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same issue here - Plex notifications no longer work in the the latest update. I get the same 500 Internal Server Error that pengc99 posted. Guess I'll attempt to rollback to a previous known good.
Edit: sweet,
git checkout ff36290ba50a08d004b41cbcb8649645c324797a
did the trick for me. Although now my git HEAD doesn't point to the repo, but I can deal with that later. If you do this make sure you make a backup of your SB directory first, just in case. :)Edit 2: derp derp
git reset --hard ff36290ba50a08d004b41cbcb8649645c324797a
gets us to where we were before we updated to this commit, with SB correctly realizing it is 13 commits behind (so we can update as usual once this issue is resolved in a later commit).79cb8f2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've got the same 'Please fill out necessary fields above' message despite still being at
ff36290 (never updated from that).
Edit: note that the notifications do work if the config is saved, it's just the test that doesn't work correctly
79cb8f2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jordansaints, thanks for the downgrade instructions. I am back to the last working commit and all is well.
I am never updating sickbeard again, lol
79cb8f2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same. I stopped Sickbeard, then used:
git reset --hard ff36290ba50a08d004b41cbcb8649645c324797a
then I restart Sickbeard and setup Plex again. Now it's working.
79cb8f2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The root cause is https://github.com/midgetspy/Sick-Beard/blob/development/sickbeard/helpers.py#L221
gzip encoding has been requested by getURLFileLike and Plex is honouring the request.
getURLFileLike does not support decoding and its use replaced urllib2.urlopen() without any encoding requests, it simply returns a file like object of the original source, including the compression from http.
sickbeard.helpers.readURLFileLike will however solve this and IS required anytime getURLFileLike is now called.
Infact, getURLFileLike should never have been called direct, instead sickbeard.helpers.getURL() should be used, which wraps the getURLFileLike and readURLFileLike into one.
#923 proposed