ui-flags -- Show language flags where appropriate #174

Merged
merged 1 commit into from Nov 21, 2011

Conversation

Projects
None yet
6 participants
Contributor

thezoggy commented Jun 25, 2011

Changed: Replace the 2 letter language abbreviation codes with image of the language's flag instead.
Added: Added a column on the Manage page so that language flag is shown.
Added: Show the language flag on the show page as well in the edit show drop down.

Preview:
http://zoggy.net/sb-flag1.png
http://zoggy.net/sb-flag2.png
http://zoggy.net/sb-flag3.png

Owner

midgetspy commented Jun 28, 2011

Does the lang column still show up if all shows are the same language? If not I will add that before pulling

Contributor

thezoggy commented Jun 28, 2011

lang column is only on the manage page and not on the HOME screen (i figured we could address that when you got back), i made the edit column slightly narrower to offset the addition so that the same amount of data is shown

Senaxx commented Oct 10, 2011

When this pull request is implemented this could also be used for another pull-request. The subliminal subtitle implementation. Currently it shows "srt" or the en,nl when multiple languages are downloaded. As I asked Diaoul to implement it in his Sickbeard fork he mentioned this pull-request. Subliminal integration could also profit from this pull-request.

Changed: Replace the 2 letter language abbreviation codes with image …
…of the language's flag instead.

Added: Added a column on the Manage page so that language flag is shown.
Added: Show the language flag on the show page as well in the edit show drop down.
Contributor

thezoggy commented Nov 20, 2011

re-based, fixed conflicts. should be good now.

Diaoul commented Nov 20, 2011

As subliminal supports ISO-639-1 languages, it would be greate to have all flags for ISO-639-1 languages.
@thezoggy: do you think this is possible? where did you get those flags?

midgetspy added a commit that referenced this pull request Nov 21, 2011

Merge pull request #174 from thezoggy/ui-flags
ui-flags -- Show language flags where appropriate

@midgetspy midgetspy merged commit fde11e1 into midgetspy:master Nov 21, 2011

Is that normal?! It should be left as Active I think!

Contributor

thezoggy replied Nov 28, 2011

Active is something different.. if the show is paused AND status is continuing. This only shows if its paused.. hence I changed the label to reflect it.

Well ok, but it shows the "Yes" image when the show is NOT paused, so there is still something wrong, no?

Contributor

thezoggy replied Nov 28, 2011

you are correct, should be a 1 not a 0. its been wrong for all this time :x

Hehe :) I also tried to point this out here

Contributor

thezoggy replied Nov 28, 2011

these are language flags not countries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment