Email notifications #242

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
4 participants
@ivanfilippov

Working implementation of email notifications on non-secure SMTP server. Addresses Google Code issue #1911 (http://code.google.com/p/sickbeard/issues/detail?id=1191)

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Dec 13, 2011

Please implement this!

ghost commented Dec 13, 2011

Please implement this!

@icovada

This comment has been minimized.

Show comment
Hide comment
@icovada

icovada Jan 14, 2012

Magnificent, exactly what I was looking for.
Let us not forget good old email

icovada commented Jan 14, 2012

Magnificent, exactly what I was looking for.
Let us not forget good old email

@xombiemp

This comment has been minimized.

Show comment
Hide comment
@xombiemp

xombiemp Mar 12, 2012

Contributor

Does this work using Gmail as the SMTP server? I'm guessing not because you state "on non-secure SMTP server".

Contributor

xombiemp commented Mar 12, 2012

Does this work using Gmail as the SMTP server? I'm guessing not because you state "on non-secure SMTP server".

@ivanfilippov

This comment has been minimized.

Show comment
Hide comment
@ivanfilippov

ivanfilippov Mar 12, 2012

It doesn't work on servers with SSL/TLS security like the ones Gmail provides. It should be trivial to add if this ever gets merged.

It doesn't work on servers with SSL/TLS security like the ones Gmail provides. It should be trivial to add if this ever gets merged.

@xombiemp

This comment has been minimized.

Show comment
Hide comment
@xombiemp

xombiemp Mar 12, 2012

Contributor

You should add it now! I would love to see this get merged, and I think you'll have a better chance if it supports SSL/TLS.

Contributor

xombiemp commented Mar 12, 2012

You should add it now! I would love to see this get merged, and I think you'll have a better chance if it supports SSL/TLS.

@ivanfilippov

This comment has been minimized.

Show comment
Hide comment
@ivanfilippov

ivanfilippov Mar 12, 2012

Good point xombiemp, I'll try to have a look at this next week, as I'm a bit busy for the next little while.

Good point xombiemp, I'll try to have a look at this next week, as I'm a bit busy for the next little while.

@gregsheremeta

This comment has been minimized.

Show comment
Hide comment
@gregsheremeta

gregsheremeta Dec 6, 2013

This is still open? 2 years?

This is still open? 2 years?

UnPoilTefal pushed a commit to UnPoilTefal/Sick-Beard that referenced this pull request Oct 19, 2015

Merge pull request #242 from abibouba/patch-1
Update strings for cleaning subs
@ivanfilippov

This comment has been minimized.

Show comment
Hide comment
@ivanfilippov

ivanfilippov Apr 11, 2016

Pretty sure this functionality was implemented between 2011 and 2016. Closing PR.

Pretty sure this functionality was implemented between 2011 and 2016. Closing PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment