Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Notifiers: XBMC / Plex - cleanup and update #524

Merged
merged 8 commits into from Nov 15, 2012

Conversation

Projects
None yet
5 participants
Contributor

thezoggy commented Nov 7, 2012

  • XBMC notifier was completely redone to support both the legacy http api and the upcoming xbmc12 (frodo) json-rpc method. Using the public calls as wrappers with the detection to know which internal methods to call.
  • Due to the XBMC rewrite, the Plex notifier no longer inherits xbmc's notifier as the code has diverged too much -- plus we were wrongly showing 'xbmc' log messages.
  • Cleaned up many small bugs I found in the process as well as updated the config ui notification page.
  • Cleaned up the notifiers page to match the web ui, which made it easier to test and for others to add notifiers in the future.

midgetspy and others added some commits Oct 17, 2012

Cleanup the notifiers order so that it matches the config ui page (ai…
…d in testing changes), fixed notifio from being done out of order (was missing from the internal notifiers list).
Stop NMJ from always sending notices (was not respecting the enable c…
…heckbox). Document NMJ's abnormal library routine to fire on notify_download rather than when doing a library update. Prob will fix this when I go back through all the notifiers to fix the numerous bugs I've discovered.
Revamp XBMC notifier to branch logic to use either the legacy HTTP AP…
…I or the newer JSON-RPC API when applicable. Cleaned up the config notifications and test functions response to better handle multiple hosts. Now we only send the library update commands to the FIRST xbmc host listed if there are multiple servers provided. This was needed to keep SB from messing up XBMC setups that use sql.

aaearon commented Nov 9, 2012

With XBMC the 20121108 3b7a2ab nightly, was able to send a test notification to XBMC successfully.

midgetspy added a commit that referenced this pull request Nov 15, 2012

Merge pull request #524 from thezoggy/dev--xbmc_json_cleanup
Notifiers: XBMC / Plex - cleanup and update

@midgetspy midgetspy merged commit 20a3e18 into midgetspy:development Nov 15, 2012

This works great. Well done. When will this be added to the master branch?

Contributor

thezoggy commented Nov 22, 2012

when we are ready to push out a new build.. not too much longer.. but we have some bugs to fix by other recent code submissions first

@thezoggy thezoggy deleted the thezoggy:dev--xbmc_json_cleanup branch Jan 6, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment