Skip to content

qualityChooser cleanup #544

Merged
merged 2 commits into from Dec 4, 2012

2 participants

@thezoggy
thezoggy commented Dec 3, 2012
  • cleaned up the qualityChooser.js for readability and make jsHint a bit happier
  • Removed unused import, cleaned up some misc whitespace and added some padding for the searching animation on the tvdb search (new show).
  • We were importing qualityChooser.js in the inc_qualityChooser.tmpl and also in the newShow tmpl which resulted in a double loading the file..

    We should have a standard rule that we do not put javascript includes in the inc_*.tmpl files as it limits flexibility (not every page may need that .js let alone would be happy with its placement) and makes it harder to track down issues.

thezoggy added some commits Dec 3, 2012
@thezoggy thezoggy qualityChooser related cleanup
* Removed unused import, cleaned up some misc whitespace and added some padding for the searching animation on the tvdb search (new show).
* We were importing qualityChooser.js in the inc_qualityChooser.tmpl and also in the newShow tmpl which resulted in a double loading the file..

  >  We should have a standard rule that we do not put javascript includes in the `inc_*.tmpl` files as it limits flexibility (not every page may need that .js let alone would be happy with its placement) and makes it harder to track down issues.
eb20b0b
@thezoggy thezoggy Fixed some jsHint concerns and improve readability aa503e3
@midgetspy midgetspy merged commit ec26d43 into midgetspy:development Dec 4, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.