Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata tweaks and updates #789

Closed

Conversation

@thezoggy
Copy link
Contributor

commented Jan 27, 2014

  • Lots of cleanup to make things a bit more standardized.

  • Remove Synology metadata since it was just a clone of MB and does not appear to be actually used by synology units.

  • Add banner, season banner season all poster and season all banner options.

  • Remove use_banner poster override since now we have a banner option.

    This now means users can have both a poster and banner instead of one or the other (XBMC12+).

    • Migrate legacy XBMC poster + use_banner setup to just banner option (keeps old functionality).

    Notice that on XBMC the banner and poster result in the same name, if you have both checked off it will just create folder.jpg with a poster since we don't overwrite existing metadata.

thezoggy added 12 commits Jan 15, 2014
Remove legacy Metadata conversion (pre-ini migration). Due to db min …
…version checking, this can be safely dropped as it is 3+ years old.
Correct layout style for metadata options in the UI. The slight incor…
…rect offset became noticeable with more options being added.
renamed: season_thumbnails -> season_posters
added initial support to do: season_posters, season_banners, season_all_images (default)
 -- wired it up so they all key off season_posters for the moment (so I wouldn't have to code up the migration/backend just yet).
added initial support to do: banner
 -- wired it up so it keys off poster for the moment (so I wouldn't have to code up the migration/backend just yet).
More reorder/cleanup/rename to make everything a bit more sensible. C…
…reate `create_season_banners` and do the backend work.
Remove `use_banner` since now we have a `banner` option. Migrate lega…
…cy XBMC poster+use_banner setup to just banner option.
Add `season-all-poster' and `season-all-banner` support. Updated and …
…reordered things so things are a bit more standardized. Tweak some logging/docstrings to reflect correct verbiage.

Note: It appears that the retrieveShowMetadata tries to work off the currently selected provider's metadata, but really in fact it only works off tvshow.nfo (xbmc/xbmc12+) -- this really should be moved out of generic and just into XBMC only (which xbmc12 subclasses from) or rewritten to support other metadata format (which is only mediabrowser at this time).

@ghost ghost closed this in 6a2e1f8 Jan 30, 2014

@thezoggy thezoggy deleted the thezoggy:dev--metadata_migration_updates branch May 5, 2014

gborri pushed a commit to gborri/Sick-Beard that referenced this pull request Sep 12, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.