Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix axios typings and upgrade to v1 #2379

Merged
merged 2 commits into from Oct 13, 2022
Merged

Conversation

czy88840616
Copy link
Member

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@gitpod-io
Copy link

gitpod-io bot commented Oct 12, 2022

@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2022

Codecov Report

Base: 82.67% // Head: 82.69% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (6bc6720) compared to base (a7d2786).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2379      +/-   ##
==========================================
+ Coverage   82.67%   82.69%   +0.02%     
==========================================
  Files         457      457              
  Lines       15990    16000      +10     
  Branches     3769     3770       +1     
==========================================
+ Hits        13219    13231      +12     
+ Misses       2505     2503       -2     
  Partials      266      266              
Impacted Files Coverage Δ
packages/grpc/src/comsumer/clients.ts 100.00% <100.00%> (ø)
packages/upload/src/middleware.ts 83.20% <100.00%> (+2.33%) ⬆️
packages/upload/src/parse.ts 93.54% <100.00%> (+0.63%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@czy88840616 czy88840616 merged commit f0666f0 into main Oct 13, 2022
@czy88840616 czy88840616 deleted the fix_axiox_definition branch October 13, 2022 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants