Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validate typing and config #1388

Merged
merged 2 commits into from
Nov 27, 2021
Merged

fix: validate typing and config #1388

merged 2 commits into from
Nov 27, 2021

Conversation

czy88840616
Copy link
Member

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@gitpod-io
Copy link

gitpod-io bot commented Nov 27, 2021

@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2021

Codecov Report

Merging #1388 (bfe9b11) into 3.x (e4595d3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              3.x    #1388   +/-   ##
=======================================
  Coverage   81.68%   81.69%           
=======================================
  Files         301      301           
  Lines       10261    10263    +2     
  Branches     2246     2248    +2     
=======================================
+ Hits         8382     8384    +2     
  Misses       1714     1714           
  Partials      165      165           
Impacted Files Coverage Δ
packages/validate/src/config.default.ts 100.00% <ø> (ø)
packages/validate/src/decorator/validate.ts 100.00% <ø> (ø)
packages/validate/src/configuration.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4595d3...bfe9b11. Read the comment docs.

@czy88840616 czy88840616 changed the title Fix validate typing fix: validate typing and config Nov 27, 2021
@czy88840616 czy88840616 merged commit 0883569 into 3.x Nov 27, 2021
@czy88840616 czy88840616 deleted the fix_validate_typing branch November 27, 2021 09:59
@czy88840616 czy88840616 mentioned this pull request Dec 8, 2021
51 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants