Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): add type DecoratorMetaData for custom decorator #2693

Merged
merged 4 commits into from Jan 31, 2023

Conversation

waitingsong
Copy link
Member

@waitingsong waitingsong commented Jan 31, 2023

增加一个类型 DecoratorMetaData
自己项目就不用重复定义了,也避免 metadata 存储类型变化导致的关联问题

@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2023

Codecov Report

Base: 82.02% // Head: 81.85% // Decreases project coverage by -0.17% ⚠️

Coverage data is based on head (0bf48aa) compared to base (de41ae3).
Patch coverage: 100.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2693      +/-   ##
==========================================
- Coverage   82.02%   81.85%   -0.17%     
==========================================
  Files         419      419              
  Lines       15019    15019              
  Branches     3562     3562              
==========================================
- Hits        12319    12294      -25     
- Misses       2450     2469      +19     
- Partials      250      256       +6     
Impacted Files Coverage Δ
packages/core/src/interface.ts 100.00% <ø> (ø)
packages/core/src/service/decoratorService.ts 92.23% <100.00%> (ø)
packages/oss/src/manager.ts 31.70% <0.00%> (-53.66%) ⬇️
packages/oss/src/configuration.ts 60.00% <0.00%> (-40.00%) ⬇️
packages/bootstrap/src/manager/cp.ts 88.88% <0.00%> (-5.56%) ⬇️
packages/bootstrap/src/util.ts 90.32% <0.00%> (+3.22%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@czy88840616 czy88840616 added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Jan 31, 2023
@czy88840616 czy88840616 merged commit 170921f into midwayjs:main Jan 31, 2023
@czy88840616
Copy link
Member

rename to MethodDecoratorMetaData and ParameterDecoratorMetaData #2693

@waitingsong waitingsong deleted the types-core branch February 1, 2023 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Development

Successfully merging this pull request may close these issues.

None yet

3 participants