Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tsigGenerate/VerifyProvider public #1382

Merged
merged 1 commit into from Jun 21, 2022
Merged

Make tsigGenerate/VerifyProvider public #1382

merged 1 commit into from Jun 21, 2022

Conversation

miekg
Copy link
Owner

@miekg miekg commented Jun 20, 2022

Make it public as TsigGenerateWithProvider and update the docs a little.

Signed-off-by: Miek Gieben miek@miek.nl

@jelu
Copy link

jelu commented Jun 21, 2022

This is only for generation, my PR was for verification also.

@miekg can you make tsigVerifyProvider public also?

Make it public as TsigGenerateWithProvider and update the docs a little.
And TsigVerifyWithProvider also - tweak those docs also a little.

Signed-off-by: Miek Gieben <miek@miek.nl>
@miekg miekg changed the title Make tsigGenerateProvider public Make tsigGenerate/VerifyProvider public Jun 21, 2022
jelu
jelu approved these changes Jun 21, 2022
Copy link

@jelu jelu left a comment

LGTM

@miekg miekg merged commit 69924a0 into master Jun 21, 2022
6 checks passed
@miekg miekg deleted the tsigprovider branch Jun 21, 2022
aanm pushed a commit to cilium/dns that referenced this issue Jul 29, 2022
Make it public as TsigGenerateWithProvider and update the docs a little.
And TsigVerifyWithProvider also - tweak those docs also a little.

Signed-off-by: Miek Gieben <miek@miek.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants