Get q to build
#8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using go1.7.1 on Darwin/amd64, with github.com/miekg/dns at db96a2b : The `q` example was not compiling, with errors which mostly show that this code couldn't compile on any version of Go I know of, before. Not just library changes, but fundamental issues of undeclared variables. This commit gets `q` to compile; I can invoke it and do some basic queries.
|
Ah, great missed during the last PR. Adding travis builds as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using go1.7.1 on Darwin/amd64, with github.com/miekg/dns at db96a2b :
The
qexample was not compiling, with errors which mostly show thatthis code couldn't compile on any version of Go I know of, before. Not
just library changes, but fundamental issues of undeclared variables.
This commit gets
qto compile; I can invoke it and do some basicqueries.