Fix bug where followUserFollowers wasn't checking limits #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great! Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I was using this library and I think I found a small bug:
maxFollowsPerHourandmaxFollowsPerDaywhere not being checked.After digging a little I discovered that the function
throttle()was being called only at the begging of the functionfollowUserFollowers()L477. But if you look a little further there is aforL504 where the "user following thing" is done. So I added another call tothrottle()at the end of the loop where the condition callsfollowCurrentUser(follower). That way the max limits are checked every time after a new user is followed.Hope I was clear.