Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MP4 tag information lost after output #33

Closed
V-Toll opened this issue May 11, 2017 · 6 comments
Closed

MP4 tag information lost after output #33

V-Toll opened this issue May 11, 2017 · 6 comments

Comments

@V-Toll
Copy link

V-Toll commented May 11, 2017

Hey! Thanks for the great app. I love the minimalistic design and the overall speed.
I just have a problem with some lost tag information in mp4 files. Thinks like cover, publisher, etc. get lost after cutting a mp4 file.

Here you see the original tag information in the mp4 file, created via MusicBrainz Picard:
1

And after putting it through LosslessCut the following happens:
2

I didn't test ist with any other video file formats.
I hope this get's fixed sometime in the near feature. Thanks!

@mifi
Copy link
Owner

mifi commented May 14, 2017

LosslessCut offloads all this conversion to ffmpeg, so we need to figure out how to make ffmpeg do this. Seems like ffmpeg has an option -map_metadata
If you can try with ffmpeg and confirm this works, then I could add an option for preserving metadata. (maybe not safe to do it by default)

See also:
https://ffmpeg.org/ffmpeg.html

@V-Toll
Copy link
Author

V-Toll commented Jun 23, 2017

Hey, this seems to work for me. Any chance of getting this function as an additional option?

@mifi
Copy link
Owner

mifi commented Jun 23, 2017

What do you mean works for you? where does it work for you?

@V-Toll
Copy link
Author

V-Toll commented Aug 3, 2017

Sorry, it's been a while ;-)

I tried the -map_metadata option with ffmpeg and all metadata was saved.

@mifi
Copy link
Owner

mifi commented Aug 14, 2017

Which arguments are you using for -map_metadata?

Looking at ffmpeg docs, it seems that global metadata is copied by default. is not MP4 tag information global metadata?

By default, global metadata is copied from the first input file, per-stream and per-chapter metadata is copied along with streams/chapters. These default mappings are disabled by creating any mapping of the relevant type. A negative file index can be used to create a dummy mapping that just disables automatic copying.

@mifi
Copy link
Owner

mifi commented Sep 14, 2017

I have added -map_metadata 0 and it seems to be working. 61a13ce

@mifi mifi closed this as completed Sep 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants