#22 Generex.requote improvements: #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkopichenko
commented
Jul 2, 2019
vkopichenko
commented
- escape @&"<#~ automaton special chars
- proper handling of multiple adjacent quote groups
- support for multiline patterns
- compiled regex caching
- exhaustive test case for everything above
* escape @&"<#~ automaton special chars * proper handling of multiple adjacent quote groups * support for multiline patterns * compiled regex caching * exhaustive test case for everything above
[ERROR] Source option 5 is no longer supported. Use 6 or later. [ERROR] Target option 1.5 is no longer supported. Use 1.6 or later. Initially Java level was missing in pom that caused problems when importing project into IntelliJ IDEA. I've checked that https://repo1.maven.org/maven2/com/github/mifmif/generex/1.0.2/generex-1.0.2.jar was built with Java 5 and added this explicitly into pom. Now have to revert this to make CI build to pass. Would happily use Java 8 features in the fix and the test, BTW.
…553247272 [ERROR] Source option 5 is no longer supported. Use 6 or later. [ERROR] Target option 1.5 is no longer supported. Use 1.6 or later. Have to bump java version to 6. Bump further right to 8 may be considered too.
…553253525 [ERROR] Failed to execute goal org.codehaus.mojo:cobertura-maven-plugin:2.6:instrument (verification) on project generex: Execution verification of goal org.codehaus.mojo:cobertura-maven-plugin:2.6:instrument failed: Plugin org.codehaus.mojo:cobertura-maven-plugin:2.6 or one of its dependencies could not be resolved: Could not find artifact com.sun:tools:jar:0 at specified path /usr/local/lib/jvm/openjdk11/../lib/tools.jar Had to switch from cobertura to jacoco due to mojohaus/cobertura-maven-plugin#30 still not resolved. Plus minor build and javadoc improvements.
…553275106 [ERROR] Failed to execute goal org.codehaus.mojo:findbugs-maven-plugin:3.0.3:findbugs (findbugs) on project generex: Unable to parse configuration of mojo org.codehaus.mojo:findbugs-maven-plugin:3.0.3:findbugs for parameter pluginArtifacts: Cannot assign configuration entry 'pluginArtifacts' with value '${plugin.artifacts}' of type java.util.Collections.UnmodifiableRandomAccessList to property of type java.util.ArrayList Updating findbugs version per https://stackoverflow.com/questions/53676071/maven-clean-command-java-util-collections-unmodifiablerandomaccesslist-to-prope.
Closed
|
Can this PR be merged anytime soon? I’m having this problem as well. Thanks. |
|
@sch111, the project seems to be orphan. As I even had to fix broken travis-ci builds in this PR and no reaction followed since then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.