Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple audio files / audio files for all words or components of words in one field #38

Closed
weirdalsuperfan opened this issue Oct 14, 2019 · 1 comment

Comments

@weirdalsuperfan
Copy link

@weirdalsuperfan weirdalsuperfan commented Oct 14, 2019

Type:

  • bug
  • feature
  • enhancement
  • question

Environment:

  • OS: Windows

I'm going to open a PR to resolve the issue:

  • yes
  • no

Description:
There's only one feature from the old NHK accent addon (or at least the dev branch of it that I maintained) that doesn't seem to have been fully carried over to this one, and that's the ability for audio/accent graphs to be generated for multiple words at once. This is especially useful for compound words, since sentences are sort of already covered by the click to listen functionality. For example, some text I ran the old addon on gave the following results (although this example is also covered by click-to-listen, I guess...although it fails with e.g. forvo, but that's a different addon):
input: [悪性/良性]腫瘍
output: [sound:悪性.yomi0006D45B_0266.wav][sound:悪性.yomi0006D463_02FA.wav][sound:悪性.yomi0006D46C_009E.wav][sound:良性.yomi0009E915_00C2.wav]

(although in this case 腫瘍 wasn't found, for some reason I don't remember)

On the other hand, this does "work" (in that it can parse this to find the audio):
input: 鰊・鯡
output: [sound:にしん.yomi00024700_0078.mp3]

so it seems like the infrastructure for doing this exists.

There are various ways to design this: it could always return the audio for all components, it could give it only when the full value of the field isn't found, it could give all components with 2 or more characters (seems reasonable to me), or maybe something else. It would work for both compound words with no clear boundaries between components, and for sentences.

@weirdalsuperfan
Copy link
Author

@weirdalsuperfan weirdalsuperfan commented Oct 14, 2019

eh, nevermind, I guess. Click to listen seems to work well enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.