migaku-official / Migaku-Japanese-Addon

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inconsistent conversion #42

Closed

grenzionky opened this issue Nov 19, 2019 · 1 comment

grenzionky commented Nov 19, 2019

Type:

bug
feature
enhancement
question

Environment:

OS: Manjaro Linux x86_64
Host: 13Z970-A.AAS5U1 0.1
Kernel: 5.3.7-2-MANJARO
WM: awesome

but this has nothing to do with my environment

Going to open a PR:

yes
no, cuz im not sure how it was set up. but if someone can tell me, then ill know for the future what to do

Description:
The conversion to the old japanese spelling system gives inconsistent conversions.

the upper line is display-type="kanji" and the lower 2 lines are both display-type="coloredkanjireading"

the upper line converts ヨウ to ヤウ, but on the second line it doesnt.
on the third it converts 今一 to ヰマイチ even though いま was never ゐま

Collaborator

LucasMIA commented Feb 20, 2020

Historical conversion is more of a gimmick feature than anything, we do not plan to invest time into making it work perfectly.

LucasMIA closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.