Skip to content

/ Migaku-Japanese-Addon

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customize colors for light/dark mode #48

Closed
JHerseth opened this issue Feb 11, 2020 · 2 comments
Closed

Customize colors for light/dark mode #48

JHerseth opened this issue Feb 11, 2020 · 2 comments

Comments

@JHerseth
Copy link

@JHerseth JHerseth commented Feb 11, 2020 •
edited

Type:

  • bug
  • feature
  • enhancement
  • question

Environment:

  • OS: Win10

I'm going to open a PR to resolve the issue:

  • yes
  • no

Description:
With Dark Mode comming to native anki, would it be posible to customize the colors for light and dark mode respectively?
@LucasMIA
Copy link
Collaborator

@LucasMIA LucasMIA commented Feb 20, 2020

Allowing this sort of customization would raise the complexity of the add-on more than we aiming to.
@LucasMIA LucasMIA closed this Feb 20, 2020
@JHerseth
Copy link
Author

@JHerseth JHerseth commented Mar 6, 2020 •
edited

@LucasMIA How about making it just configurable through the config.json? All it takes is a small edit of the getJapaneseCss function. Would you accept a pull request?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@JHerseth @LucasMIA
You can’t perform that action at this time.