Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Furigana when looking up words #66

Open
RumovZ opened this issue Sep 9, 2020 · 0 comments
Open

Use Furigana when looking up words #66

RumovZ opened this issue Sep 9, 2020 · 0 comments

Comments

@RumovZ
Copy link

@RumovZ RumovZ commented Sep 9, 2020

Type:

  • bug
  • feature
  • enhancement
  • question

Environment:

  • OS: all

I'm going to open a PR to resolve the issue:

  • yes
  • no, I think...

Description:
The add-on could make use of any existing Furigana to find the right entry in the dictionary. This would be immensely useful in two scenarios:

  1. Correct Furigana already exists. Instead of replacing it with autogenerated Furigana, the add-on could keep the existing Furigana and add further information like pitch accent only when the reading of the entry matches.
  2. The add-on inserted a wrong reading. This can usually be fixed by the user ad hoc, but the pitch accent information will also be wrong and has to be found with an external tool. If the pitch generation could be run again using the manually adjusted reading, no further tool would be needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.