Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for http patch and delete method in forti client ems #196 #197

Conversation

patrikspiess
Copy link
Member

@patrikspiess patrikspiess commented Feb 23, 2024

  • The two HTTP methods PATCH and DELETE were added to FortiClientEMS
  • Login logic for FortiClientEMS was extended to catch and reuse the csrftoken
  • Tests were optimized and extended
  • Additional fun was added to the developers life

I'm aware that not all added parts (e.g. requests.session.headers handling) are optimal and very professional. But for now it works quite good and improvements can be made in a next iteration.

closes #196

Copy link
Collaborator

@lucmurer lucmurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, man!

@lucmurer lucmurer merged commit 59135c0 into migros:main Mar 5, 2024
5 checks passed
@patrikspiess patrikspiess deleted the Support-for-HTTP-PATCH-and-DELETE-method-in-FortiClientEMS-#196 branch April 3, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for HTTP PATCH and DELETE method in FortiClientEMS
2 participants