Bug 2002420: making sure stage labels are added to running pods only #1198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Valid bug 2002420 |
|
This fixed the test case mentioned in https://bugzilla.redhat.com/show_bug.cgi?id=2002420 for me. ACK |
djwhatle
approved these changes
Sep 8, 2021
|
@JaydipGabani if you have IBM ROKS clusters around, would be good to test the same TC on your end in case there is different PVC behavior there. Thinking about the scenario where a |
JaydipGabani
changed the title
sseago
reviewed
Sep 8, 2021
pkg/controller/migmigration/stage.go
Outdated
| if pod.Status.Phase != corev1.PodRunning { | ||
| continue | ||
| } | ||
| if pod.DeletionTimestamp == nil { |
There was a problem hiding this comment.
Isn't this the opposite of what we want? If it's deleted, we skip it. If it's not deleted, we annotate it.
There was a problem hiding this comment.
Ohh! Good catch!!
sseago
approved these changes
Sep 8, 2021
|
Re-tested after recent change set, still works 👍 |
JaydipGabani
added a commit
to JaydipGabani/mig-controller
that referenced
this pull request
Sep 9, 2021
…igtools#1198) * making sure stage labels are added to stage pods only * making sure stage labels are added to running pods only (cherry picked from commit 63f8c54)
JaydipGabani
added a commit
that referenced
this pull request
Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip adding stage labels to pods that are not in running state