Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix discovery debug tree filtering on PVBs/PVRs #723

Merged
merged 1 commit into from Oct 29, 2020
Merged

Fix discovery debug tree filtering on PVBs/PVRs #723

merged 1 commit into from Oct 29, 2020

Conversation

djwhatle
Copy link
Contributor

@djwhatle djwhatle commented Oct 29, 2020 •
edited

Fixes migtools/mig-ui#1049

This endpoint was returning all PodVolumeRestores (I had 260) instead of just the single PodVolumeRestore that was performed during my migration.

Before

curl --silent http://localhost:8080/namespaces/openshift-migration/plans/plan-foo/tree | grep -o PodVolumeRestore | wc -l                                                       
     260

After

curl --silent http://localhost:8080/namespaces/openshift-migration/plans/plan-foo/tree | grep -o PodVolumeRestore | wc -l
       1

@djwhatle djwhatle requested a review from jortel October 29, 2020 17:07
@djwhatle djwhatle mentioned this pull request Oct 29, 2020
Closed
@djwhatle djwhatle marked this pull request as draft October 29, 2020 17:39
@djwhatle djwhatle marked this pull request as ready for review October 29, 2020 17:43
@djwhatle djwhatle mentioned this pull request Oct 29, 2020
Closed
jortel
jortel approved these changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@jortel jortel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djwhatle djwhatle merged commit 055770e into migtools:master Oct 29, 2020
@djwhatle djwhatle added the kind/bug Categorizes issue or PR as related to a bug. label Nov 18, 2020
djwhatle added a commit that referenced this pull request Nov 18, 2020
@djwhatle
Fix discovery debug tree filtering on PVBs/PVRs (#723)
0904432 
(cherry picked from commit 055770e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jortel jortel jortel approved these changes

Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migration plan resources (DEBUG) view shows all PVRs/PVBs. This should be a filtered list.
2 participants
@djwhatle @jortel