Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update controller name and role #528

Merged
merged 1 commit into from Dec 14, 2020
Merged

Update controller name and role #528

merged 1 commit into from Dec 14, 2020

Conversation

jmontleon
Copy link
Collaborator

Description

Check each of the following when appropriate to help reviewers verify work is complete.

Modifying an existing version

  • I modified operator permissions in the OLM CSV and operator.yml
  • I modified the operator deployment in the OLM CSV and operator.yml
  • I modified operand permissions in the OLM CSV and ansible role
  • I modified CRDS in the OLM CSV and ansible role

Adding a new release version

  • I created a new z release directory in deploy/olm-catalog/konveyor-operator
  • I updated channels in the konveyor-operator.package.yaml
  • I created a new release directory in deploy/non-olm
  • I created or updated the major.minor link in deploy/non-olm
  • I updated the spec.skips parameter in the CSV

@jmontleon jmontleon added controller-bound Needs a simultanious merge with one or more mig-controller PRs 1.4.0 labels Dec 14, 2020
@jmontleon jmontleon self-assigned this Dec 14, 2020
@jmontleon
Copy link
Collaborator Author

https://bugzilla.redhat.com/show_bug.cgi?id=1894293

@jmontleon
Copy link
Collaborator Author

If the cam container exists on the deployment during an upgrade we need to delete the deployment first, which requires some additional logic.

@djwhatle djwhatle mentioned this pull request Dec 14, 2020
Merged
djwhatle
djwhatle approved these changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@djwhatle djwhatle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VISACK

@djwhatle
Copy link
Contributor

Related to migtools/mig-controller#858

@jmontleon jmontleon merged commit 9c264de into migtools:master Dec 14, 2020
jmontleon added a commit that referenced this pull request Dec 14, 2020
@jmontleon
Update controller name and role (#528)
49cd8f7 
(cherry picked from commit 9c264de)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djwhatle djwhatle djwhatle approved these changes

Assignees

@jmontleon jmontleon

Labels
1.4.0 controller-bound Needs a simultanious merge with one or more mig-controller PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jmontleon @djwhatle