Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update storage form to show proper type when editing for azure/gcp #1083

Merged
merged 3 commits into from Dec 11, 2020
Merged

Update storage form to show proper type when editing for azure/gcp #1083

merged 3 commits into from Dec 11, 2020

Conversation

ibolton336
Copy link
Contributor

Fixes BZ 1882061

  • When editing, we werent setting the provider type for the storage before rendering the storage form. This PR fixes this for GCP/Azure provider types.

@ibolton336 ibolton336 requested a review from a team December 8, 2020 16:54
pranavgaikwad
pranavgaikwad approved these changes Dec 11, 2020
View reviewed changes
Copy link
Contributor

@pranavgaikwad pranavgaikwad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@ibolton336 ibolton336 merged commit c9ecced into migtools:master Dec 11, 2020
@ibolton336 ibolton336 deleted the edit-azure-test branch December 11, 2020 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranavgaikwad pranavgaikwad pranavgaikwad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ibolton336 @pranavgaikwad