Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update whitelist/blacklist to support pods #1118

Merged

Conversation

betocantu93
Copy link
Contributor

@betocantu93 betocantu93 commented Dec 27, 2019

Adds support for blacklist/whitelist with pod components.

Use only whitelist or blacklist, NOT both.

As a reminder, whitelist is an array of components which will be included in the build, as well as all of their dependencies...

i.e

['ember-paper']: {
  whitelist: ['paper-autcomplete']
}

Would only include into the build:

[
      'paper-autocomplete',
      'paper-autocomplete/ebd-trigger',
      'paper-autocomplete/eps-trigger',
      'paper-autocomplete/ebd-content',
      'paper-autocomplete/options',
      'paper-autocomplete/no-matches-message',
      'paper-autocomplete/highlight'
]

If nested, the "path" must be specified

['ember-paper']: { 
      whitelist: [
        'paper-autocomplete/ebd-trigger'
      ]
}

Blacklist is harder to get right, use with caution, as it would only exclude this particular component.

['ember-paper']: { 
      blacklist: [
        'paper-autocomplete/ebd-trigger'
      ]
}

@miguelcobain miguelcobain merged commit ac6b142 into miguelcobain:master Dec 29, 2019
@miguelcobain
Copy link
Owner

Thanks a lot @betocantu93 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants