assigning local ret variable to none if the asyncio task is canceled #164
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the async namespace's trigger_event routine the ret variable is not assigned any value if the async task is canceled. This causes some IMO unnecessary exceptions.
python-socketio/socketio/asyncio_namespace.py
Lines 36 to 39 in ce44133
I have assigned it to none as it is done in
python-socketio/socketio/asyncio_server.py
Lines 324 to 327 in 3b702da