New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work on imports. WIP: Other pointers. #26

Merged
merged 6 commits into from Sep 3, 2014

Conversation

Projects
None yet
2 participants
@amitjamadagni

amitjamadagni commented Aug 31, 2014

  • put the Link import in a all.py file
  • The documentation of homology_generators is still not clear.
  • is_alternating should work also for links.
  • Your code to compute the PD code from the braid is too bloated.
  • The ncomponents method is wrong:

sage: B=BraidGroup(5)
sage: b=B([1,1,1,1,1])
sage: b.permutation()
[2, 1]
sage: b.permutation().to_cycles()
[(1, 2)]

This would lead to conclude that the corresponding link has only one
component, but in fact it has four (three of which are trivial circles
unlinked).

  • check on the pd code.
  • returning in tuples than in lists.

miguelmarco added a commit that referenced this pull request Sep 3, 2014

Merge pull request #26 from amitjamadagni/week15
Work on imports. WIP: Other pointers.

@miguelmarco miguelmarco merged commit 1a6b0b4 into miguelmarco:knots Sep 3, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment