Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System 6 graphical glitches #95

Closed
Sgeo opened this issue Jan 26, 2023 · 8 comments
Closed

System 6 graphical glitches #95

Sgeo opened this issue Jan 26, 2023 · 8 comments

Comments

@Sgeo
Copy link

Sgeo commented Jan 26, 2023

https://system6.app is unusable

image

Chrome 109

@mihaip
Copy link
Owner

mihaip commented Jan 26, 2023

Looks OK to me:

image

This is with Chrome 109.0.5414.119 on macOS 12.6.2 on an M1 MacBook Pro. Where are you running it?

@Sgeo
Copy link
Author

Sgeo commented Jan 26, 2023

Windows 10 with a nVidia GeForce RTX 2070.

Just remembered that I had the ANGLE backend set to OpenGL. Changing it to Default resolves the problem.

@mihaip
Copy link
Owner

mihaip commented Jan 26, 2023

Thanks for confirming. System 6/Mini vMac ends up using the "dirty rect" option of putImageData, which perhaps is buggy in that implementation.

@mihaip mihaip closed this as completed Jan 26, 2023
@terminalgt
Copy link

im getting this kind of graphic glitch
chrome os 105
Screen recording 2023-02-15 11.41.37 AM.webm

@mihaip
Copy link
Owner

mihaip commented Feb 16, 2023

@terminalgt I don't currently have access to a Chrome OS device. If you visit chrome://flags, do you have a setting for "ANGLE Graphics Backend", and if so, what is it set to?

image

@Sgeo
Copy link
Author

Sgeo commented Feb 16, 2023

Glitching on Chrome on my Pixel 7. As far as I can tell, there is no ANGLE setting on here.

Interestingly, after taking a screenshot and editing, things seem to improve, as though a repaint helped

Screenshot_20230215-220157
Screenshot_20230215-220216
Screenshot_20230215-220231
Screenshot_20230215-220256

@that-ben
Copy link

that-ben commented Feb 17, 2023

This makes me happy that I use Firefox and not Chrome. Wow :P

@mihaip
Copy link
Owner

mihaip commented Mar 4, 2023

Will look into detecting this and disabling the dirty rect optimization in that case, since it seems to be pretty common on Android and ChromeOS devices.

@mihaip mihaip reopened this Mar 4, 2023
@mihaip mihaip closed this as completed in 436eed6 Mar 5, 2023
mihaip added a commit that referenced this issue Mar 30, 2023
mihaip added a commit that referenced this issue Mar 30, 2023
Not having one appears to be buggy in non-macOS versions of Chrome (even
when disabling the dirty rect optimization).

Since there was no tangible benefit to it on macOS, better to remove
the `alpha: false` flag so that we can simplify the code.

Updates #135
Updates #95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants