Unit test to demonstrate #15 #29
Conversation
This unit test is for testing concave polygons with the extrusion feature.
In this unit test I create 2 concave polygons. These polygon data is derrived from a path iterator used to create fonts. The 2 letters chosen are a capital H and lower case e (just the outer shape, the inner hole has been removed from this dataset to demonstrate a specific problem). The 2 sets of points are extruded and the number of polygons displayed of the 2. When a simple union of non intersecting CSG's is performed, the total number of polygons should not change.
Conflicts: .gitignore
|
This will fail the travis build because it includes a unit test that demonstrated a fault and at this time is not passing. |
|
Thanks for preparing the test. I'll have a look at it. |
Your assumption in the test is wrong. The increased number of triangles does not come from bad orientation etc. Just try this with regular primitives such as two spheres and it will fail as well if you don't enable optimization. |
|
How would i enable optimizations? |
|
See your unit test. I modified it to work properly. But I doubt that this Dipl.-Math. Michael Hoffer Twitter: @mihosoft Goethe-Zentrum für Wissenschaftliches Rechnen (G-CSC) 2016-11-12 20:42 GMT+01:00 Kevin Harrington notifications@github.com:
|
|
Why is this mode not the default? |
|
Because it does not work 100% reliable. There are edge cases that I didn't test so far. |
I wrote a stripped down unit test to demonstrate the issue i have been describing in #15 . This unit test will test to see that when the extrude function is called on convex polygons, that the triangulation function does not fall off the edge and begin placing triangles inside out.