New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter mechanical games, improve BIOS identification #45

Open
nullpainter opened this Issue Sep 18, 2018 · 2 comments

Comments

Projects
2 participants
@nullpainter
Contributor

nullpainter commented Sep 18, 2018

As noted on arcadecontrols.com, mechanical games (i.e., fruit machines) shouldn't be included in the game list.

I suspect we are implicitly filtering these anyway as the majority appear to only be partially emulated, however there is an ismechanical attribute for mechanical games in the listxml output, so it makes sense to filter by this.

There are also isbios and isrunnable flags so we should also check for these rather than just rely on the emulation status. Adding these checks pared down my list of games slightly, so clearly our status check wasn't quite good enough.

nullpainter added a commit to nullpainter/mamesaver that referenced this issue Sep 18, 2018

@mika76

This comment has been minimized.

Owner

mika76 commented Sep 18, 2018

Good stuff - filtering the list is always good - it's so frustrating to run into the odd game that does not want to work in the screensaver...

@mika76 mika76 added this to To do in v3 via automation Sep 18, 2018

@mika76 mika76 added the enhancement label Sep 18, 2018

@mika76 mika76 added this to the v2.1 milestone Sep 18, 2018

@mika76 mika76 moved this from To do to In progress in v3 Sep 18, 2018

@nullpainter

This comment has been minimized.

Contributor

nullpainter commented Oct 24, 2018

Resolved by PR #49.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment