Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated post match #117

Closed
cwchristerw opened this issue Nov 14, 2018 · 4 comments
Assignees
Labels

Comments

@cwchristerw
Copy link
Contributor

@cwchristerw cwchristerw commented Nov 14, 2018

RUNNING LOCALLY DOES REVEAL THIS KIND OF MESSAGE FOR ALL POSTS
Deprecation: A call to '{% post_url 2015-05-29-graduation %}' did not match a post using the new matching method of checking name (path-date-slug) equality. Please make sure that you change this tag to match the post's name exactly.

@cwchristerw

This comment has been minimized.

Copy link
Contributor Author

@cwchristerw cwchristerw commented Nov 14, 2018

HOW TO REPEAT THIS TO GET THE MESSAGE
Install to local machine using docker or local installation, get instructions for that in #116

@Mikaela Mikaela added the on hold label Nov 14, 2018
@Mikaela

This comment has been minimized.

Copy link
Owner

@Mikaela Mikaela commented Nov 14, 2018

I have faint idea of GitHub running too old version that doesn't support that format, but I am not entirely sure and that was a very long time ago, so hopefully the situation has changed since then.

@Mikaela Mikaela self-assigned this Feb 2, 2019
@Mikaela Mikaela pinned this issue Apr 21, 2019
@Mikaela Mikaela referenced this issue Jul 13, 2019
0 of 18 tasks complete
@Mikaela

This comment has been minimized.

Copy link
Owner

@Mikaela Mikaela commented Jul 13, 2019

OK, so it wants me to add the directory in front of it. As everything is in blog/_posts and _posts disappears in the URL, the warning you quoted is fixed by:

-[I graduated on 2015-05-29.]({% post_url 2015-05-29-graduation %})*
+[I graduated on 2015-05-29.]({% post_url blog/2015-05-29-graduation %})*

I guess this isn't so painful to fix, I will change a few and then push and if GitHub doesn't complain, I will keep on pushing.

Mikaela added a commit that referenced this issue Jul 13, 2019
Ref: #117
@Mikaela

This comment has been minimized.

Copy link
Owner

@Mikaela Mikaela commented Jul 13, 2019

Judging by https://github.com/Mikaela/mikaela.github.io/deployments I am correct and can fix this. I should also really fix Travis.

@Mikaela Mikaela added Working on it and removed on hold labels Jul 13, 2019
Mikaela added a commit that referenced this issue Jul 13, 2019
@Mikaela Mikaela closed this in 1133a8a Jul 13, 2019
@Mikaela Mikaela unpinned this issue Jul 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.