Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #193 - windows actions + Upgrades SnoreToast to v0.7.0 #293

Merged
merged 11 commits into from Nov 15, 2019

Conversation

@yoavain
Copy link
Contributor

@yoavain yoavain commented Oct 28, 2019

  • Updated SnoreToast to 0.7.0
  • Support SnoreToast "-b" flag for action buttons
  • Communicate with SnoreToast using unique named pipes
  • Parse result from pipe into data object before calling the actionJackerDecorator
  • Sanitizing data now changes "timedout" to "timeout"
  • Sample file
  • package.json script to run toaster with actions
  • Sample gif for README
yoavain added 6 commits Oct 27, 2019
* Updated SnoreToast to 0.7.0
* Support SnoreToast "-b" flag for action buttons
* Communicate with SnoreToast using unique named pipes
* Parse result from pipe into data object before calling the actionJackerDecorator
* Sanitizing data now changes "timedout" to "timeout"
* Sample file
* package.json script to run toaster with actions
* Sample gif for README
* Sample gif for README
@yoavain
Copy link
Contributor Author

@yoavain yoavain commented Oct 29, 2019

I saw the build is broken. Will have a look...

yoavain added 2 commits Oct 29, 2019
* Revert test to work as before
* Change toaster back to sync function, that uses callback
@yoavain yoavain changed the title Issue #193 - windows actions Issue #193 - windows actions + Upgrades SnoreToast to v0.7.0 Oct 29, 2019
yoavain added a commit to yoavain/screwzira-subtitle-downloader that referenced this issue Nov 9, 2019
Copy link
Collaborator

@jnielson94 jnielson94 left a comment

Thanks for the contribution @yoavain ! I left a couple comments from glancing at the code, and I should have some time later tonight to pull it down and run it to make sure things look good. I'm gonna go ahead and approve, but I won't merge it yet. Ideally we'll get a review from @mikaelbr when he's got a few minutes :)

README.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@jnielson94 jnielson94 requested a review from mikaelbr Nov 14, 2019
yoavain and others added 2 commits Nov 14, 2019
Co-Authored-By: Jordan Nielson <jnielson94@gmail.com>
Co-Authored-By: Jordan Nielson <jnielson94@gmail.com>
test/toaster.js Outdated Show resolved Hide resolved
Co-Authored-By: Jordan Nielson <jnielson94@gmail.com>
Copy link
Owner

@mikaelbr mikaelbr left a comment

Thanks for this and the great work! It looks good to me. Could you also extend the documentation readme to include basic usage for this?

Is there any way we could align the action types with macOS? Or show an example which is cross OS friendly?

@jnielson94
Copy link
Collaborator

@jnielson94 jnielson94 commented Nov 15, 2019

@mikaelbr & @yoavain I'm going to go ahead and merge this since it works :) I'll look into making the cross OS (which I think is just toasters and notification center) work more smoothly so that in an ideal world the existing way notification center actions works will work here too.

@jnielson94 jnielson94 merged commit b368131 into mikaelbr:master Nov 15, 2019
1 check passed
@yoavain
Copy link
Contributor Author

@yoavain yoavain commented Nov 15, 2019

Thanks for this and the great work! It looks good to me. Could you also extend the documentation readme to include basic usage for this?

Is there any way we could align the action types with macOS? Or show an example which is cross OS friendly?

I will try and open another PR for the documentation.

Regarding the cross OS:
SnoreToast distinguish between the following actions on the notifications:
"activate" (when clicking the notification)
"dismissed" (when dragging the notification out of the screen)
"timeout" (when not doing anything)
and now with the buttons, we have an action per button.
(There's another one which I did not handle - TextEntered)

I was trying to support all these actions, and I might missed on keeping it cross-platform friendly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants