Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NotifySend support for app name #299

Merged
merged 1 commit into from Apr 8, 2020
Merged

NotifySend support for app name #299

merged 1 commit into from Apr 8, 2020

Conversation

@gabrielfern
Copy link
Contributor

@gabrielfern gabrielfern commented Dec 17, 2019

Hello, notify-send has an option to set the app name, but I couldn't be able to pass that option through node-notifier, so I made the additions that enables people to use that option if they want to, using node-notifier.
Although it seems notify-send man page doesn't say anything about this option, it's definitively there, I tested the option under some Ubuntu based systems and notify-send recognizes the option, also you can find information about the option from other sources like this one notify-send options.
One thing this option does is let you change the "notify-send" default app name, that shows in the notification no matter what in some notifications system.
For example, executing notifier.notify({title: 'Hello Message', message: 'This is a node-notifier message'}) and we get:
Screenshot_20191217_040932
But after these changes, you can do notifier.notify({title: 'Hello Message', message: 'This is a node-notifier message', 'app-name': 'node-notifier'}) to get:
Screenshot_20191217_041029

screenshots taken from KDE plasma, and ubuntu based system

@mikaelbr
Copy link
Owner

@mikaelbr mikaelbr commented Apr 8, 2020

Thanks! Took long to merge this, but looks good to me.

@mikaelbr mikaelbr merged commit aef0da8 into mikaelbr:master Apr 8, 2020
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants