Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API call for fetching all notifications #7

Merged

Conversation

rgould
Copy link
Contributor

@rgould rgould commented Sep 18, 2019

Bit more complex than the others due to the paging involved

@rgould
Copy link
Contributor Author

rgould commented Sep 25, 2019

Updated to address bug found by @danroux

@MatteoJoliveau
Copy link
Collaborator

Hello @rgould, thank you for this contribution and sorry for the long delay. We have resumed maintenance on this project, will look into your PR asap

Copy link
Collaborator

@bernardini687 bernardini687 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the long delay @rgould, we're finally reviewing the PRs now.
thanks for your contribution!

@MatteoJoliveau MatteoJoliveau merged commit f8d4087 into mikamai:develop Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants