Skip to content

Mike Burns
mike-burns

Organizations

@thoughtbot @bostonandroid @trusthoarder @codesthlm @bitptr @mnfst
mike-burns commented on pull request thoughtbot/pick#99
@mike-burns

This project uses a non-recursive makefile. For some documentation on that, I recommend https://autotools.io/automake/nonrecursive.html .

mike-burns commented on pull request thoughtbot/suspenders#713
@mike-burns

Two of the three Ruby files changed exist only for Heroku -- heroku.rb and app.json. So does this change affect Heroku?

mike-burns commented on pull request thoughtbot/suspenders#713
@mike-burns

I found where the build pack cares about RACK_ENV: https://github.com/heroku/heroku-buildpack-ruby/blob/master/lib/language_pack/rack.rb#L45 And RA…

mike-burns commented on pull request thoughtbot/pick#99
@mike-burns

This is beautiful. Can this make use of the autotools TAP test infrastructure, such that the check target (and especially distcheck target) run th…

mike-burns closed pull request thoughtbot/rcm#174
@mike-burns
fix sha256 for tar.gz package
mike-burns commented on pull request thoughtbot/rcm#174
@mike-burns

Thanks for catching that. Merged as 1ce1a4a.

@mike-burns
mike-burns commented on pull request thoughtbot/guides#387
@mike-burns

Saying "with a transpiler" seems unnecessary; either the latest JS syntax is supported by all our browsers, in which case we don't need a compiler,…

mike-burns commented on pull request thoughtbot/guides#386
@mike-burns

The JSON specification does not allow this, and Ruby chokes on this: irb(main):029:0> puts j { "a": 1, "b": 2, } => nil irb(main):030:0> puts j2 { …

mike-burns commented on pull request thoughtbot/guides#399
@mike-burns

Should this be "use" instead of "prefer"?

mike-burns commented on pull request thoughtbot/laptop#440
@mike-burns

If you use sh instead of bash this line will be two letters shorter and microseconds faster.

@mike-burns

Great catch, and now I see why @derekprior thought it should be an API change. I just tried sketching out an API that is resistant to timing attack…

mike-burns commented on pull request thoughtbot/gitsh#245
@mike-burns

@georgebrock it looks like INSTALL.in generates INSTALL, but it didn't for 0.10.

@mike-burns

As I understand it, the strategy's #authenticated? method (e.g. https://github.com/thoughtbot/clearance/blob/7a63a2a9363729c743693d74f725337b860ee3…

mike-burns commented on commit mhoran/tbd@bee63eec4a
@mike-burns

Stray newline.

mike-burns commented on commit mhoran/tbd@d89d68dacc
@mike-burns

These two lines are the same as: errx(1, "initialize_cef_base failed, size member not set");

mike-burns commented on pull request thoughtbot/laptop#445
@mike-burns

I like it.

mike-burns commented on pull request thoughtbot/laptop#445
@mike-burns

You'll want $LOGNAME instead of $USER - some details on this commit message: thoughtbot/rcm@a801c4c

@mike-burns
mike-burns commented on pull request thoughtbot/rcm#155
@mike-burns

I learned something about the Debian shell today: ~% dash $ cd /dev $ L='ls w*' $ $L watchdog watchdog0 watchdog1 $ IFS=" > " $ $L dash: 6: ls w*: …

mike-burns closed pull request thoughtbot/rcm#172
@mike-burns
Add MacPorts installation instructions
mike-burns commented on pull request thoughtbot/rcm#172
@mike-burns

Merged as a80ea10. Thank you!

@mike-burns
  • @casey a80ea10
    Add MacPorts installation instructions
mike-burns commented on pull request thoughtbot/hound-jshint#5
@mike-burns

In the least you could extract it to a well-named constant. How about unconfiguredConfig?

mike-burns commented on commit mhoran/tbd@90d82fb4bd
@mike-burns

This is a size_t in the docs, but you're using -1 as a sentinel, so maybe expectingDataSize could be a ssize_t and you could cast to size_t on this…

mike-burns commented on commit mhoran/tbd@90d82fb4bd
@mike-burns

If processNext produced the int instead of mutating it, this could read: expectingDataSize = processNext(cmd, buffer, client, expectingDataSize); A…

mike-burns commented on commit mhoran/tbd@90d82fb4bd
@mike-burns

How about checking the return from fgets(3) instead of checking feof(3) manually? Like: if (fgets(buffer, sizeof(buffer), stdin) == NULL) return;

mike-burns commented on pull request thoughtbot/laptop#438
@mike-burns

Yup, I like it.

mike-burns commented on pull request thoughtbot/hound#1035
Something went wrong with that request. Please try again.