Mike Burns mike-burns

Organizations

@thoughtbot @bostonandroid @trusthoarder @codesthlm @bitptr @mnfst
mike-burns commented on pull request accesslint/access_lint-app#44
@mike-burns

I can't think of how to hack that. LGTM.

mike-burns commented on pull request accesslint/access_lint-app#44
@mike-burns

It is passed as an attribute to the #tag method as an attribute value, which is passed to #tag_options with escape set to true. This causes it to e…

mike-burns commented on pull request thoughtbot/capybara_discoball#4
@mike-burns

Cool, thanks for documenting how it really works. LGTM. (Though it'd be nice to not require that block.)

mike-burns commented on pull request thoughtbot/guides#348
@mike-burns

I like this because this is how we write dictionaries in Python. (But really: if this is what the community at large does, we should probably do it.)

mike-burns commented on pull request thoughtbot/guides#347
@mike-burns

Super grammatical nitpick but this feels more like an e.g. than an i.e. to me ("for example" instead of "that is").

mike-burns commented on pull request thoughtbot/guides#341
@mike-burns

This is a tool, like any other. You're always allowed to use tools. This doesn't seem like an appropriate thing for the guides to even mention; it …

mike-burns commented on pull request namely/connect#147
@mike-burns

That's not a field in the form. Rather, the namely_field_name is tracked by its index in the array of field_mappings on an AttributeMapper (using a…

@mike-burns
  • @mike-burns a5c7e34
    See what makes Hound happy
@mike-burns
mike-burns opened pull request namely/connect#147
@mike-burns
Edit the field mapping
6 commits with 146 additions and 8 deletions
@mike-burns
@mike-burns
  • @mike-burns 1fe6b88
    Persist the field mapping
@mike-burns
@mike-burns
@mike-burns
@mike-burns
  • @mike-burns a1480cf
    Document how to make a custom export
mike-burns created branch dox at namely/connect
mike-burns commented on pull request namely/connect#146
@mike-burns

My hunch is that we will replace #call with #export entirely and drop the mapping_direction, but I'm interested to see what NetSuite::Export will l…

mike-burns commented on pull request namely/connect#146
@mike-burns

You can shorten this by two lines with Enumerable#each_with_object: def export(profile) field_mappings.each_with_object({}) do |field_mapping, acc| if

mike-burns commented on pull request thoughtbot/hound#853
@mike-burns

I'm glad this is a light wrapper around flake8. I've no concrete feedback on the Python code. CC @thoughtbot/python .

mike-burns commented on pull request thoughtbot/hound#853
@mike-burns

Can you change these values to one that look more obviously like dummy data?

mike-burns commented on pull request thoughtbot/suspenders#590
@mike-burns

I do agree with that reasoning, but I also worry about staging and production being different. If even tiny code can cause problems, I want to catc…

mike-burns commented on pull request namely/connect#145
@mike-burns

Yup.

mike-burns commented on pull request namely/connect#145
@mike-burns

Mostly curious why there is a default. I'm not sure if any default makes sense here, but I'm also not opposed. Thanks for the explanation.

mike-burns commented on pull request namely/connect#145
@mike-burns

Cool. I'm interested to see how this will connect with the rest of the system -- currently nothing uses this code?

mike-burns commented on pull request namely/connect#145
@mike-burns

Default 0?

mike-burns commented on pull request thoughtbot/hound#853
@mike-burns

@teoljungberg this PR is for making use of an existing external service, like what we do with SCSS. I have not been following Hound closely, but is…

mike-burns commented on pull request thoughtbot/suspenders#564
@mike-burns

Aside from bikesheds about the name of this variable, is this idea good to merge? Alternatively we can close this PR.

mike-burns closed pull request namely/connect#144
@mike-burns
Missing secrets are blank 401